1

Closed

[Performance] Remove calls to BufferedDataReader.AssertFieldIsReady

description

We can shave a bit of time of buffered materialization performance by not calling this assert in Release. We should still call it when in Debug.
Closed Nov 20, 2013 at 10:20 PM by Mugdhak
Closed by code review

comments

divega wrote Nov 11, 2013 at 5:56 PM

Note for triage: this is a tiny and trivial change and contributes to the improvement for buffering queries, especially observable when they are no-tracking. Andrew's ad-hoc testing showed ~3% improvement but we are still waiting for the full perf runs.

My recommendation is to just take it now but 6.1 would also be ok.

emilcicos wrote Nov 15, 2013 at 12:23 AM

Fixed in changeset fd6470d91fb886e6dbfa644557a8bd6a0512ccc0

emilcicos wrote Nov 15, 2013 at 5:37 AM

Fixed in changeset e7feee087090decb5127fe11f9f1d1fa535ba08e