1
Vote

ArgumentValidation asserts for EdmProperty with null DeclaringType

description

EdmProperty.Primitive is now public. When trying to use it with DbExpressionBuilder like this it may cause asserts:
        var propertyExpression = 
            DbExpressionBuilder.Property(
                DbExpressionBuilder.Constant(42),
                EdmProperty.Primitive("Everything", PrimitiveType.GetEdmPrimitiveType(PrimitiveTypeKind.Int64)));
Since the declaring type is null. We should probably throw for this case and review other places in the DbExpressionBuilder where we assume that things that previously were not constructible publicly are set up correctly.

comments

RoMiller wrote Dec 12, 2013 at 9:13 PM

EF Team Triage: Moving issues with Impact set to Low out of the 6.1.0 release as we only have time to address High and Medium issues in this release. We will re-triage these issues for future releases.

This does not exclude someone outside of the Microsoft EF team from contributing the change/fix in 6.1.0.