1

Closed

Breaking change in DbExpressionVisitor classes

description

It appears that we made a breaking change when adding DbInExpression support. Specifically, new abstract members were added to the generic and non-generic DbExpressionVisitor classes:
    /// <summary>
    ///     Typed visitor pattern method for DbInExpression.
    /// </summary>
    /// <param name="expression"> The DbInExpression that is being visited. </param>
    /// <returns> An instance of TResultType. </returns>
    public abstract TResultType Visit(DbInExpression expression);


    /// <summary>
    ///     Visitor pattern method for DbInExpression.
    /// </summary>
    /// <param name="expression"> The DbInExpression that is being visited. </param>
    public abstract void Visit(DbInExpression expression);
We should either decide to explicitly make a breaking change and force new providers to support the new expression or make these methods virtual, throw, and ensure that they are not called if the provider has not opted in to the new feature.
Closed Mar 19, 2013 at 6:55 PM by BriceLambson

comments

mgirgin wrote Jan 11, 2013 at 7:49 PM

Consider for EF6

BriceLambson wrote Mar 19, 2013 at 6:49 PM

Fixed in changeset 65caaa498ada (by Emil)

BriceLambson wrote Mar 19, 2013 at 6:55 PM

Verified.