http://entityframework.codeplex.com/SourceControl/list/changesetsentityframework Source Code Rss Descriptionhttp://entityframework.codeplex.com/SourceControl/changeset/25ca7aa7fd0c195cf3fa689585420d142f9d31b0Migrations: Fix for #1216 - History table warning when scripting

Problem: After adding ContextKey to the PK of the history table the combined PK length was greater than the SQL Server allowed maximum (900 bytes).
Solution: Reduce the total size of the composite PK to not exceed the 900 byte limit. Ensure that we enforce migration id max length at creation time.

Work Item: 1216
AndrewPetersTue, 18 Jun 2013 19:58:01 GMTSource code checked in, #25ca7aa7fd0c195cf3fa689585420d142f9d31b0 20130618075801Phttp://entityframework.codeplex.com/SourceControl/changeset/b695ab94704b380acfbdbe036e2db9a459cc4c82Removing AsStreaming extension generic constraint
Removing null check for server name in ExecutionStrategyKey constructor
Adding a constructor to SqlAzureExecutionStrategy

Work items: 1164, 1166, 1201
AndriySvyrydTue, 18 Jun 2013 17:51:41 GMTSource code checked in, #b695ab94704b380acfbdbe036e2db9a459cc4c82 20130618055141Phttp://entityframework.codeplex.com/SourceControl/changeset/4505dd693e2f19b0b7aea66ec3a26aaf5107275cRan code cleanup.
AndrewPetersTue, 18 Jun 2013 16:48:08 GMTSource code checked in, #4505dd693e2f19b0b7aea66ec3a26aaf5107275c 20130618044808Phttp://entityframework.codeplex.com/SourceControl/changeset/7ee2c87b858f6d1c746cd7eb583a8b81cf97bd93Restoring correct indentation of SPROC bodies in generated migrations
AndrewPetersTue, 18 Jun 2013 16:48:06 GMTSource code checked in, #7ee2c87b858f6d1c746cd7eb583a8b81cf97bd93 20130618044806Phttp://entityframework.codeplex.com/SourceControl/changeset/18e91c98ee3c65254701fd395321f224ba9355f4Per pull-request review:

- Remove HardTabString and "\t" where used.

- Renamed AppendKeyWord to AppendKeyword and removed CodeAnalysis message suppression.

- Added newly needed CodeAnalysis message suppressions.

- Reduced fragility of unit test by collapsing whitespace.
AndrewPetersTue, 18 Jun 2013 16:48:05 GMTSource code checked in, #18e91c98ee3c65254701fd395321f224ba9355f4 20130618044805Phttp://entityframework.codeplex.com/SourceControl/changeset/4539642889f0ba2d8efa01005798df2c4be400a7Changed expected strings to match new indentation (should probably be less fragile tests)
AndrewPetersTue, 18 Jun 2013 16:48:03 GMTSource code checked in, #4539642889f0ba2d8efa01005798df2c4be400a7 20130618044803Phttp://entityframework.codeplex.com/SourceControl/changeset/2d9af3740c1318ab4080c5e0b05c32570d9e7585- Added ability to IndentedTextWriter to cache indentation string so
we don't incur massive string-allocations for white-space. Explicitly
exposed the forced culture (InvariantCulture) so users won't guess
wrong if passing in their own TextWriter.

- Made SqlWriter simply inherit from IndentedTextWriter so it could
benefit from the caching and migrated the "only a new-line" logic
down to IndentedTextWriter for consistent emission of indentation.

- SqlStringBuilder now exposes the InnerBuilder for use when we would
be just making a StringBuilder and passing it to Append later. This
allows the underlying to be used without constant newing of new
builders, and also allows TextWriters (particularly
IndentingTextWriters) to just append directly.

- DmlSqlGenerator now wraps the _commandText.InnerBuilder to
eliminate newing up a StringBuilder and copying of strings by
writing directly into the _commandText.

- Eliminated the sqlCE's need for AppendFormat on the
sqlCE version SqlStringBuilder, just for some concatenation.

- SqlServerMigrationSqlGenerator, CShareMigrationCodeGenerator,
and VisualBasicCodeGenerator use the writer's CurrentIdentation
method directly (again to benefit from the cache).

(at this point, I think we should move IndentedTextWriter,
SqlWriter, and SqlStringBuilder into EntityFramework proper)
AndrewPetersTue, 18 Jun 2013 16:48:02 GMTSource code checked in, #2d9af3740c1318ab4080c5e0b05c32570d9e7585 20130618044802Phttp://entityframework.codeplex.com/SourceControl/changeset/3083d0b18a558e14408c5a80ab99adabc3860b5cMaking some conventions more extensible.

Workitem: 731
AndriySvyrydMon, 17 Jun 2013 23:22:47 GMTSource code checked in, #3083d0b18a558e14408c5a80ab99adabc3860b5c 20130617112247Phttp://entityframework.codeplex.com/SourceControl/changeset/8fe61609ca3b3fd0aaaa4c912aba31d17042d34eMade mapping API internal and exposed them to designer with InternalsVisibleTo
Emil CicosMon, 17 Jun 2013 19:23:20 GMTSource code checked in, #8fe61609ca3b3fd0aaaa4c912aba31d17042d34e 20130617072320Phttp://entityframework.codeplex.com/SourceControl/changeset/6cf455ba81c9b9a018dd2b20ba9d8b17971783acMigrations: Log messages raised by the Sql(Ce)Connection.InfoMessage event

Problem: Bug #1216 identified a problem in that command execution warnings generated by ADO.NET providers are not surfaced in the default migrations UX.
Solution: Updated the logging decorator to capture warnings during command execution. Unfortunately, the InfoMessage event used to intercept warnings is not part of the ADO provider surface, so I had to add surface to our provider model to enable hooking the provider specific event.
AndrewPetersMon, 17 Jun 2013 17:29:36 GMTSource code checked in, #6cf455ba81c9b9a018dd2b20ba9d8b17971783ac 20130617052936Phttp://entityframework.codeplex.com/SourceControl/changeset/003d32b753ce0096ee4ee9f9abe9d81a5d34c146CountCheapula: For Work Item: 1089 Performance enhancement for EntityAdapter.IsStateManagerDirty method

This is a contribution from IDisposable to replace uses of GetObjectStateEntriesCount and GetObjectStateEntries with a new method HasChanges that doesn't bother getting or counting any entries but just returns true as soon as it is known that there is something that needs to be saved.
ajcvickersFri, 14 Jun 2013 02:46:08 GMTSource code checked in, #003d32b753ce0096ee4ee9f9abe9d81a5d34c146 20130614024608Ahttp://entityframework.codeplex.com/SourceControl/changeset/07586120afab14f7a2f0df07d58192c4e356f298Avoiding throwing exceptions when spatial services are requested from the provider if they aren't available, unless they are required to continue.

Workitem: 1113, 1225
AndriySvyrydWed, 12 Jun 2013 00:21:28 GMTSource code checked in, #07586120afab14f7a2f0df07d58192c4e356f298 20130612122128Ahttp://entityframework.codeplex.com/SourceControl/changeset/4f810f94765f49ee019d2e0c5482f3b078947344Unifying IEdmConvention and IDbConvention into IModelConvention and adding overloads that accept a DataSpace to distinguish them.

Making IDbMappingConvention internal as there is no public API that it can use to modify the mapping.

Workitem: 1048
AndriySvyrydWed, 12 Jun 2013 00:18:03 GMTSource code checked in, #4f810f94765f49ee019d2e0c5482f3b078947344 20130612121803Ahttp://entityframework.codeplex.com/SourceControl/changeset/0184dc24e0ca03fbcbfc68268c7bb664c7a28a09Adding more verification to HasPrecision

Workitem: 1047
AndriySvyrydTue, 11 Jun 2013 18:35:22 GMTSource code checked in, #0184dc24e0ca03fbcbfc68268c7bb664c7a28a09 20130611063522Phttp://entityframework.codeplex.com/SourceControl/changeset/ca249bedacaeef66484a0730f22a11f1b242559dWhoGotTheFunc (CodePlex 396: Handle closures containing DbSet/DbQuery members)

The code we previously had for this was broken in that it only handled DbQuery/DbSet members that were typed as IQueryable. However, this was already almost fixed in EF6 with the change to handle funcletization of DbQueries directly in LINQ to Entities. The one tweak needed to make this case work and remove the need for the translation in the wrapping provider was to make sure that the expression type of the ObjectQuery expression created by the funcletizer is ObjectQuery or a derivation. The code was previously just using the type of the expression passed in, which was okay when the expression coming in was an ObjectQuery, but not okay if it was a DbQuery that had been converted to an ObjectQuery.
ajcvickersMon, 10 Jun 2013 16:59:29 GMTSource code checked in, #ca249bedacaeef66484a0730f22a11f1b242559d 20130610045929Phttp://entityframework.codeplex.com/SourceControl/changeset/48bca474b6697f0ea20f4595284858a0e901a569Fixing build break
AndrewPetersMon, 10 Jun 2013 16:42:14 GMTSource code checked in, #48bca474b6697f0ea20f4595284858a0e901a569 20130610044214Phttp://entityframework.codeplex.com/SourceControl/changeset/cf6619faf28cffd3b2f07c46213056a5406dfdd8Merge branch 'master' of https://git01.codeplex.com/entityframework
AndrewPetersFri, 07 Jun 2013 21:31:22 GMTSource code checked in, #cf6619faf28cffd3b2f07c46213056a5406dfdd8 20130607093122Phttp://entityframework.codeplex.com/SourceControl/changeset/fc5166a68cb4331885c11066a493e004de9c9685Runtime: Two fixes:

1) #1136 - Make update command trees publicly constructible

Solution: Made the ctors public and also added ToString() to DbCommandTree. ToString calls Print() which renders a textual version of the tree - highly useful when debugging/testing trees.

2) #1190 - Code First Stored Procs :: exception thrown when using stored procs to map entity with self reference and 1-1 reference to another entity with non-int key

Problem: When generating update trees for entities involved in one-to-one associations using IAs, we first need to change the relationship state to deleted before setting it to added.
Solution: Make the additional call to ChangeRelationshipState when this case is detected. In order to make the call, we need to fabricate a second stub principal entity and that entity needs a key different from the stub entity we are using to set the relationship state to added (otherwise state manager validation will fail), so I had to add the ability to generate fake key values for the stub principal. I also noticed that we were not handling spatial keys correctly and so I fixed that too.

Work Item: 1136, 1190
AndrewPetersFri, 07 Jun 2013 21:30:36 GMTSource code checked in, #fc5166a68cb4331885c11066a493e004de9c9685 20130607093036Phttp://entityframework.codeplex.com/SourceControl/changeset/23ba9d87176d0f4a3140c7dad5f273329a20c7c1EfHasNoRestrictions (CodePlex 1212: Remove OperationAction.Restrict)

OperationAction.Restrict is not supported by EF. This changes removes all places (that I could find) where it is referred to.
ajcvickersFri, 07 Jun 2013 20:44:26 GMTSource code checked in, #23ba9d87176d0f4a3140c7dad5f273329a20c7c1 20130607084426Phttp://entityframework.codeplex.com/SourceControl/changeset/9ae70370f474d9f6044a1491a475705f2fd0b384CodePlex #643 - Updated code to remove stale association types and to use column information from SSpace instead of CSpace when copying foreign key constraint.
Emil CicosFri, 07 Jun 2013 19:01:00 GMTSource code checked in, #9ae70370f474d9f6044a1491a475705f2fd0b384 20130607070100P